chore: add AWS bootstrap js + update urls #4614
Merged
+180
−367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
documentation
pull-request-size
bot
added
size/XL
leandrodamascena
requested review from
sdangol
and removed request for
leandrodamascena and
svozza
|
Please review this @sdangol. |
hjgraca
reviewed
Oct 6, 2025
hjgraca
reviewed
Oct 6, 2025
hjgraca
reviewed
Oct 6, 2025
|
Do we want to make these URL's versioned instead of using /latest in them? |
|
We don't have a process to update them when we release, and they work at the best of my knowledge. For now I'd leave them like this, so we can get the analytics going. |
|
Thank you both for the review, fixed the API urls. |
|
dreamorosi
changed the title
sdangol
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR adds the AWS bootstrap JS file to the docs pages and also updates the base URL for the docs in all occurrences throughout the codebase.
For an easier review, I suggest to focus on the first commit, which adds the bootstrap script.
The second commit is an automated find & replace with the old and new url respectively.
The third commit removes the now outdated analytics script.
The fourth commit updates the Discord badge button with a working image.
Issue number: closes #4611
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.